Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to adjust the home directory #7759

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

StefanSpieker
Copy link
Contributor

Explain how to adjust the home directory.
Not sure how broadly it is used, but there was a TODO and I thought describing it might not hurt.

@StefanSpieker StefanSpieker requested a review from a team as a code owner December 16, 2024 17:54
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Dec 16, 2024
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is accurate and matches with the usages that I found.

content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
Co-authored-by: Mark Waite <[email protected]>
Co-authored-by: Kris Stern <[email protected]>
@StefanSpieker
Copy link
Contributor Author

Thanks for the suggestions, and thanks @MarkEWaite for checking the usages. I was a little surprised that this is so rarely used, but I see a few use cases also in the plugins I maintain.

Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @StefanSpieker, I've provided a couple minor suggestions for word placement/grammar, but nothing that should prevent this from being merged.

If there are any issues with what I've suggested, or if they change the context/instruction too much, feel free to disregard.

content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
@kmartens27 kmartens27 merged commit 8384cca into jenkins-infra:master Dec 17, 2024
6 checks passed
@StefanSpieker StefanSpieker deleted the jenkins_home branch December 18, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants